Update optimality to use negative epsilon measure#4
Merged
Conversation
…e euclidian distance - Updated the measure calculation - Re-minimized all of the needed files
…y-convexity into epsilon-measure
shanest
approved these changes
Apr 17, 2026
Contributor
shanest
left a comment
shanest
left a comment
There was a problem hiding this comment.
Awesome, looks great! I think find_epsilon_measure could be "vectorized" so that it takes in a whole bunch of points instead of a single one, but I see tat it's natural to call it with a single point when building the data frame, so not going to bother requesting that change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates optimality to use negative epsilon measure as was suggested by reviewers. I recalculated all of the minimized files too.